Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline deletion tool that searches and collects stale blocks #1134

Merged
merged 3 commits into from
Apr 30, 2015

Conversation

kuenishi
Copy link
Contributor

Supercedes #1124 . Changes since #1124 are:

  • Offline delete tool:
    • Improved success count by checking delete oks
    • Add an option to support old Riak 1.4 key format
    • Add -mode(compile).
    • Add serious warning and interactive input for running Riak process
  • Select-gc tool:
    • Change name of options from/to to start/end
    • Remove -l option for leeway; use start/end
    • Add -mode(compile).

Also, for fallbacks, I'd rather expect hinted handoff works and then delete with this tool. This is to prevent this script from being more complex, from operational mistake and from further bugs.

@kuenishi kuenishi added this to the 2.1.0 milestone Apr 28, 2015
@kuenishi kuenishi modified the milestones: 2.2.0, 2.1.0 Apr 28, 2015
@shino
Copy link
Contributor

shino commented Apr 30, 2015

for fallbacks, I'd rather expect hinted handoff works and then delete with this tool. This is to prevent this script from being more complex

Agree. Then, it's prerequisite (or recommended at least) to finish hinted handoff before running the scripts.

offline_delete(BitcaskDir, BlocksListFile, false, false);
main(_) ->
io:format(standard_error,
"options: [--dry-run][--old-format] <BitcaskDir> <BlocksListFile>~n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space between two options?

@kuenishi
Copy link
Contributor Author

Updated

@shino
Copy link
Contributor

shino commented Apr 30, 2015

Works nice 😄

borshop added a commit that referenced this pull request Apr 30, 2015
Offline deletion tool that searches and collects stale blocks

Reviewed-by: shino
@shino
Copy link
Contributor

shino commented Apr 30, 2015

@borshop merge

@borshop borshop merged commit 885f839 into develop Apr 30, 2015
@shino shino deleted the feature/offline-gc-tool-squashed branch April 30, 2015 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants