Fix URL encoding bug around AWS v4 auth [JIRA: RCS-203] #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS v4 auth defined URL encoding algorithm that is used for
generating signature. Mochiweb's utility function convert
space (" ") to plus ("+") but AWS spec says it should be
percent encoded. i.e. "%20".
This commit fixes the encoding bug for resource (URL path) and
query parameters.
cf.
Authenticating Requests by Using the Authorization Header
(Compute Checksum of the Entire Payload Prior to Transmission)
- Signature Version 4 - Amazon Simple Storage Service
http://docs.aws.amazon.com/ja_jp/AmazonS3/latest/API/sig-v4-header-based-auth.html
borshop
added a commit
that referenced
this pull request
May 1, 2015
Fix URL encoding bug around AWS v4 auth Reviewed-by: kuenishi
|
@borshop merge |
borshop
added a commit
that referenced
this pull request
May 1, 2015
Fix URL encoding bug around AWS v4 auth Reviewed-by: kuenishi
|
@borshop: retry |
Basho-JIRA
changed the title
Basho-JIRA
added
JIRA: In Progress
JIRA: Done
and removed
JIRA: To Do
JIRA: In Progress
labels
|
No release note needed as AWS v4 auth is not supported in 2.0 nor 2.1. _[posted via JIRA by Kota Uenishi]_ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS v4 auth defined URL encoding algorithm that is used for
generating signature. Mochiweb's utility function convert
space (" ") to plus ("+") but AWS spec says it should be
percent encoded. i.e. "%20".
This commit fixes the encoding bug for resource (URL path) and
query parameters.
This PR only affects AWS v4 authentication path that is still preliminary support.
cf.
Authenticating Requests by Using the Authorization Header
(Compute Checksum of the Entire Payload Prior to Transmission)
http://docs.aws.amazon.com/ja_jp/AmazonS3/latest/API/sig-v4-header-based-auth.html