Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing syslog items in config schema [JIRA: RCS-212] #1162

Merged
merged 2 commits into from
Jun 10, 2015

Conversation

ksauzz
Copy link
Contributor

@ksauzz ksauzz commented Jun 9, 2015

Riak CS fails due to missing syslog configs if one attempt to enable syslog by log.syslog=on in riak-cs.conf.

This PR also includes a small refactoring commit on tests.

Error messages

% bin/riak-cs console
19:26:45.918 [error] Error generating configuration in phase apply_translations
19:26:45.918 [error] Translation for 'lager.handlers' expected to find setting 'log.syslog.ident' but was missing
Error generating config with cuttlefish
  run `riak-cs config generate -l debug` for more information.

@kuenishi kuenishi added this to the 2.1.0 milestone Jun 10, 2015
@kuenishi
Copy link
Contributor

@ksauzz Good catch. Could you write down here the workaround you showed in the customer ticket?

@kuenishi kuenishi added the Bug label Jun 10, 2015
@ksauzz
Copy link
Contributor Author

ksauzz commented Jun 10, 2015

Workaround

Add lager configs into advanced.config including lager_syslog_backend like:

 {lager, [
          {handlers, [
                      {lager_syslog_backend, ["riak", local1, info]},
                      {lager_console_backend, info},
                      {lager_file_backend, [{file, "/var/log/riak-cs/error.log"},
                                            {level, error},
                                            {size, 10485760},
                                            {date, "$D0"},
                                            {count, 5}]},
                      {lager_file_backend, [{file, "/var/log/riak-cs/console.log"},
                                            {level, info},
                                            {size, 10485760},
                                            {date, "$D0"},
                                            {count, 5}]}
                     ]}
         ]},

app.config in Riak CS 1.5.x is a good example to set lager configs in advanced.config.

@kuenishi
Copy link
Contributor

Ah, yes. Copy and pasting from 1.5 app.config is the best way.

@kuenishi
Copy link
Contributor

@ksauzz Could you back port this to 2.0 branch as well? I think this is worth being backported.

@kuenishi
Copy link
Contributor

@Basho-JIRA open a ticket for this

borshop added a commit that referenced this pull request Jun 10, 2015
…nfig-schema

Fix missing syslog items in config schema

Reviewed-by: kuenishi
@kuenishi
Copy link
Contributor

Worked fine in my laptop

@ksauzz
Copy link
Contributor Author

ksauzz commented Jun 10, 2015

@kuenishi Will do.

@kuenishi
Copy link
Contributor

@borshop merge

@Basho-JIRA Basho-JIRA changed the title Fix missing syslog items in config schema Fix missing syslog items in config schema [JIRA: RCS-212] Jun 10, 2015
@Basho-JIRA Basho-JIRA closed this Jun 10, 2015
@Basho-JIRA
Copy link

Will also be backported to 2.0.

_[posted via JIRA by Kota Uenishi]_

@kuenishi kuenishi reopened this Jun 10, 2015
@kuenishi
Copy link
Contributor

@borshop merge

@borshop borshop merged commit 5f22da3 into develop Jun 10, 2015
@kuenishi kuenishi deleted the bugfix/missing-syslog-items-in-config-schema branch June 10, 2015 09:09
@Basho-JIRA
Copy link

Release note: Fix a configuration system bug where Riak CS could not start if log.syslog=on is set. See original pull request for workaround in 2.0.x.

_[posted via JIRA by Kota Uenishi]_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants