Add latency stats items to S3 API and velvet calls [JIRA: RCS-220] #1180
Conversation
With small callback function for each WM callback sub-modules
- Change command to switch stanchion to riak-cs-admin, avoiding depricated warning - Fix stats item number - Fix stats item name for back pressure sleep
|
Fixed riak_test failures, became ready for review actually. |
| Action = case Operation of | ||
| create -> created; | ||
| delete -> deleted; | ||
| _ -> undefined | ||
| end, |
There was a problem hiding this comment.
This indentation looks strange to me, which should be aligned with case.
|
Thanks for pointing out. Fixed as to two comments above and pushed. |
Basho-JIRA
changed the title
| ok = riak_cs_stats:update_with_start(StatName, | ||
| StartTime), | ||
| X | ||
| riak_cs_user:save_user(UpdUser, UserObj, RcPid) |
There was a problem hiding this comment.
So are we supposed to measure this call in next pull request?
There was a problem hiding this comment.
Yes. Stats in riakc calls are NOT included. Will be in next.
| @@ -157,6 +162,7 @@ delete_resource(RD, Ctx=#context{user=User, | |||
| ok -> | |||
| riak_cs_dtrace:dt_bucket_return(?MODULE, <<"bucket_delete">>, | |||
| [200], [riak_cs_wm_utils:extract_name(User), Bucket]), | |||
| ok = riak_cs_stats:update_with_start([bucket, delete], StartTime), | |||
There was a problem hiding this comment.
Why do you have update_with_start/3 here? Isn't this caught at riak_cs_wm_common:update_stats ?
|
How about adding items in |
|
Thanks for review. Pushed the fix for your comments. Please let me defer modification of |
|
|
Add latency stats items to S3 API and velvet calls [JIRA: RCS-220] Reviewed-by: kuenishi
|
nooooooooooooooooooo |
|
The fail was about eunit. All tests have succeeded but failed after that. |
|
@borshop: retry |
Add latency stats items to S3 API and velvet calls [JIRA: RCS-220] Reviewed-by: kuenishi
|
@borshop merge |
|
TODO: write down release note _[posted via JIRA by Kota Uenishi]_ |
|
This is a part of RCS-11 work; release notes will be written there. _[posted via JIRA by Kota Uenishi]_ |
Part 2 of stats improvement following #1165 (RCS-204) and address #961 (RCS-37) (RCS-217) partially.
This PR adds: