Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy_get defined in riak-cs.conf not working [JIRA: RCS-236] #1185

Merged
merged 3 commits into from
Jul 24, 2015

Conversation

kuenishi
Copy link
Contributor

Without this code you'll have excessive log output like this by default:

2015-07-21 18:35:34.842 [warning] <0.814.0>@riak_cs_config:proxy_get_active:289 proxy_get value in app.config is invalid
2015-07-21 18:35:35.949 [warning] <0.819.0>@riak_cs_config:proxy_get_active:289 proxy_get value in app.config is invalid
2015-07-21 18:35:37.534 [warning] <0.824.0>@riak_cs_config:proxy_get_active:289 proxy_get value in app.config is invalid
2015-07-21 18:35:38.381 [warning] <0.829.0>@riak_cs_config:proxy_get_active:289 proxy_get value in app.config is invalid
2015-07-21 18:35:38.957 [warning] <0.834.0>@riak_cs_config:proxy_get_active:289 proxy_get value in app.config is invalid
2015-07-21 18:35:39.834 [warning] <0.839.0>@riak_cs_config:proxy_get_active:289 proxy_get value in app.config is invalid

This is because riak_cs_config:proxy_get_active/0 handles proxy_get_active config item in riak-cs.config badly, only accepting enabled/disabled atom which could be set at advanced.config.

@kuenishi kuenishi added the Bug label Jul 13, 2015
@kuenishi kuenishi added this to the 2.1.0 milestone Jul 13, 2015
@Basho-JIRA Basho-JIRA changed the title Fix proxy_get defined in riak-cs.conf not working Fix proxy_get defined in riak-cs.conf not working [JIRA: RCS-236] Jul 13, 2015
disabled -> false;
Flag when is_boolean(Flag) -> Flag;
Other ->
_ = lager:warning("proxy_get value in riak.conf (advanced.config) is invalid: ~p",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/riak.conf/riak-cs.conf/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I was wrong.
Cuttlefish uses schema and validate values. One can not set any value other than boolean(). If invalid value is set, advanced.config is probably wrong.

@shino
Copy link
Contributor

shino commented Jul 23, 2015

Nice fix. Works as advertised. Only one fix is needed for log message before 👍

@kuenishi
Copy link
Contributor Author

Updated via web interface :P

borshop added a commit that referenced this pull request Jul 23, 2015
Fix proxy_get defined in riak-cs.conf not working [JIRA: RCS-236]

Reviewed-by: shino
@shino
Copy link
Contributor

shino commented Jul 23, 2015

@borshop merge

@Basho-JIRA
Copy link

This is a bug made during 2.1 dev cycle, so release note for this is not needed.

_[posted via JIRA by Kota Uenishi]_

@Basho-JIRA Basho-JIRA closed this Jul 23, 2015
@shino shino deleted the bugfix/proxy-get-active branch July 23, 2015 09:20
@shino
Copy link
Contributor

shino commented Jul 24, 2015

This PR was closed BEFORE merge. Why?

@shino shino restored the bugfix/proxy-get-active branch July 24, 2015 07:55
@shino shino reopened this Jul 24, 2015
@shino
Copy link
Contributor

shino commented Jul 24, 2015

@borshop merge

borshop added a commit that referenced this pull request Jul 24, 2015
Fix proxy_get defined in riak-cs.conf not working [JIRA: RCS-236]

Reviewed-by: shino
@borshop borshop merged commit 67a2d51 into develop Jul 24, 2015
@shino shino deleted the bugfix/proxy-get-active branch July 24, 2015 08:31
@shino
Copy link
Contributor

shino commented Jul 24, 2015

🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants