Add requestPayment and lifecycle stub callbacks [JIRA: RCS-272] #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to response a little more understandable response. For requestPayment, just reply XML with "BucketOwner" after authn/authz. For lifecycle, just reply error XML of "NotImplemented" without anthentication.
| @@ -71,9 +71,13 @@ base_resources() -> | |||
| {["buckets", bucket, "objects"], riak_cs_wm_common, props(riak_cs_wm_objects)}, | |||
| {["buckets", bucket, "delete"], riak_cs_wm_common, props(riak_cs_wm_bucket_delete)}, | |||
| {["buckets", bucket, "acl"], riak_cs_wm_common, props(riak_cs_wm_bucket_acl)}, | |||
| %% Just stub, no dynamic contents | |||
| {["buckets", bucket, "location"], riak_cs_wm_common, props(riak_cs_wm_bucket_location)}, | |||
There was a problem hiding this comment.
location is no more a stub because it's return value is configurable via configuration.
There was a problem hiding this comment.
Ah, reasonable :) I did so just because location does not have meaning anywhere else in riak cs (except a possibility of v4 auth.)
|
Updated. |
borshop
added a commit
that referenced
this pull request
Aug 27, 2015
…cycle-stub Add requestPayment and lifecycle stub callbacks Reviewed-by: kuenishi
|
@borshop merge |
Basho-JIRA
changed the title
Basho-JIRA
added
JIRA: To Do
JIRA: In Progress
JIRA: Needs Review
and removed
JIRA: To Do
JIRA: In Progress
labels
|
Release note: Add 501 stub for Bucket lifecycle and simple stub for Bucket requestPayment _[posted via JIRA by Kota Uenishi]_ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
lifecycleis notincluded in subresources definition of Riak CS.
In order to response a little more understandable response, this PR changes them as:
To be truthful, motivation for these changes were from s3cmd error for
s3cmd info <bucket>㊙️