Rebased "fall back on /etc/riak-cs/app.config when no generated one is found" #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case re:run(X, Pattern) of | ||
| {match, _} -> false; | ||
| nomatch -> true | ||
| end |
There was a problem hiding this comment.
?assertEqual(nomatch, re:run(..)) may be a little more concise? (and remove the first ?assert and replace lists:all() with list comprehension or lists:foreach)
There was a problem hiding this comment.
Ah, revert my comment above. The current macro exhibit better correspondence with assertMatchAny. Sorry for noice.
|
Updated for the review comments, and fixed small other bugs. |
borshop
added a commit
that referenced
this pull request
Oct 9, 2015
Rebased "fall back on /etc/riak-cs/app.config when no generated one is found" Reviewed-by: shino
|
@borshop merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a recreated PR to 2.1 branch, and adds a simple riak-test for riak-cs-debug.
original PR is #1261