Return 400 Bad Request if multipart upload does not contain upload parts #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During a multipart upload, the "complete" message should contain a list of part ids and MD5 hashes. If it is empty, we should return a 400 Bad Request, Malformed XML message like S3.
|
+1 b4491c6 |
borshop
added a commit
that referenced
this pull request
Mar 18, 2016
Return 400 Bad Request if multipart upload does not contain upload parts Reviewed-by: tburghart
|
@borshop merge |
borshop
added a commit
that referenced
this pull request
Mar 18, 2016
Return 400 Bad Request if multipart upload does not contain upload parts Reviewed-by: tburghart
|
@mrallen1 The test you mentioned is omitted because of the decorator |
|
I meant this line must be removed and get this tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a multipart upload, the "complete" message should contain a list of part ids and MD5 hashes. If it is empty, we should return a 400 Bad Request, Malformed XML message like S3. The associated test for this test is here. Addresses #1100