Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revision of the changes in #1293
That code happened to work when encoding/decoding UUIDs because their encoded length hit the midpoint in calculating how many '=' characters belong at the tail the properly encoded Base64. The padding length was calculated incorrectly, though, so variable length data wound up improperly formatted and triggered a crash if the Base64 encoding had an odd number of trailing '=' characters.
Additionally, the regular expression used in the test code would never match an improperly encoded result. Since the test only used UUIDs, which by chance produced the right result because of their length, the test never saw data that exposed the padding flaw.
These changes are cherry-picked from the RCS-366 patch branch, which was based on a different version, so some of its changes were already present (hence the apparently trivial changes). The relevant changes are those in the
base64url
module.