add riak-cs-stanchion command to switch stanchion manually #657
Conversation
assumes a use case where: 1. stanchion fails (or kill the old one, ensure killed) 2. decide a new stanchion with a brand new location (host,port) 3. put a new stanchion location via `riak-cs-stanchion switch` Also, users can confirm stanchion setting by `show` subcommand.
| %%% Public API | ||
| %%%=================================================================== | ||
|
|
||
| %% @doc Kick off a gc round, unless one is already |
There was a problem hiding this comment.
copy-paste comment maybe?
ghost
assigned
| @@ -0,0 +1,24 @@ | |||
| #!/bin/sh | |||
|
|
|||
There was a problem hiding this comment.
thoughts on a set -e for this script?
There was a problem hiding this comment.
I thought I had set this script executable. Or I messed up sth with git?
|
I like this. My biggest fear is that people won't understand that this is only a runtime change. It does not persist the change, so if Riak CS is restarted, it will revert back to the old value. Maybe a warning will help? |
|
fmm, that might be a problem, because people including me usually don't read warning. My idea, plus a warning, is to enable I can't wait built-in Rafter. |
|
Ready for review again! English composition might be a bit better. |
|
I'm merging this PR, but still open to additional or critical discussions on persistence and diversing stanchion settings. |
add riak-cs-stanchion command to switch stanchion manually
|
Cool. Thanks @kuenishi. |
Add a command to switch stanchion location setting. This command
assumes a use case where:
riak-cs-stanchion switchAlso, users can confirm stanchion setting by
showsubcommand.I believe this will make operation in case of stanchion failure much easier
than before.
I'd like to discuss about the risk that this command may lead operational
mistake to diverse stanchion settings.