Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanity_check(true,false) logs invalid error on riakc_pb_socket error #683

Merged
merged 1 commit into from
Jan 3, 2014

Conversation

reiddraper
Copy link
Contributor

When Riak is offline or the protocol buffers interface is otherwise unavailable, the sanity_check for check_bucket_props reports "Invalid Riak bucket properties detected. Please verify that allow_mult is set to true for all buckets."

This error is incorrect and misleading.

@ghost ghost assigned reiddraper Nov 18, 2013
Distinguish error message being invalid bucket properties and simply not
being able to connect to Riak during start-up.

Fixes #683
@kuenishi
Copy link
Contributor

+1

2013-12-24 22:37:36.515 [info] <0.7.0> Application folsom started on node 'riak-cs@127.0.0.1'
2013-12-24 22:37:36.534 [warning] <0.131.0>@riak_cs_app:check_bucket_props:121 Unable to verify moss.users bucket settings (disconnected).
2013-12-24 22:37:36.534 [warning] <0.131.0>@riak_cs_app:check_bucket_props:121 Unable to verify moss.access bucket settings (disconnected).
2013-12-24 22:37:36.534 [warning] <0.131.0>@riak_cs_app:check_bucket_props:121 Unable to verify moss.storage bucket settings (disconnected).
2013-12-24 22:37:36.534 [warning] <0.131.0>@riak_cs_app:check_bucket_props:121 Unable to verify moss.buckets bucket settings (disconnected).
2013-12-24 22:37:36.534 [error] <0.131.0>@riak_cs_app:sanity_check:68 Could not verify bucket properties. Error was disconnected.
2013-12-24 22:37:36.534 [error] <0.130.0> CRASH REPORT Process <0.130.0> with 0 neighbours exited with reason: {error_verifying_props,{riak_cs_app,start,[normal,[]]}} in application_master:init/4 line 138
2013-12-24 22:37:36.535 [info] <0.7.0> Application riak_cs exited with reason: {error_verifying_props,{riak_cs_app,start,[normal,[]]}}

reiddraper added a commit that referenced this pull request Jan 3, 2014
…ging

sanity_check(true,false) logs invalid error on riakc_pb_socket error
@reiddraper reiddraper merged commit bc50585 into develop Jan 3, 2014
@reiddraper reiddraper deleted the feature/better-startup-error-messaging branch January 3, 2014 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants