-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List objects FSM v2 bugfix and tests #788
Merged
reiddraper
merged 12 commits into
release/1.4
from
feature/list-objects-eqc-addition-squashed-reid-squashed
Feb 4, 2014
Merged
List objects FSM v2 bugfix and tests #788
reiddraper
merged 12 commits into
release/1.4
from
feature/list-objects-eqc-addition-squashed-reid-squashed
Feb 4, 2014
Commits on Feb 3, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 4a638a9 - Browse repository at this point
Copy the full SHA 4a638a9View commit details -
EQC properties for listing all objects
- Two EQC properties for listing objects (GET Bucket), one without delimiter and one with delimiter "/". Those properties assert following two are equal: 1. keys from listing objects by repetitive usage of riak_cs_list_objects_fsm_v2 2. active keys from generated [{State, Key},...] - When counterexample is found, states and keys are written to file $PWD/.riak_cs_list_objects_fsm_v2_eqc.txt. Each line consists of line number, status and key. Example output: 1,active,0123456/10 2,scheduled_delete,0123456/1000 - To generate manifests, generator of whole manifests is avoided and generate only states and keys of manifests. The property list-all-objects generates several thousands of nested tuples, #lfs_manifest_v3 and #acl_v2 in this case. But generators of nested tuples seem not so fast. TODOs remaining - prefix of request parameter - non-default max-keys
Configuration menu - View commit details
-
Copy full SHA for 9c81b9c - Browse repository at this point
Copy the full SHA 9c81b9cView commit details -
Clean up the list objects EQC test and start threading the 2i request page size through spawn_link of the FSM. This allows us to test with constants far below 1002. 1002 is a nice size for production 2i queries, but is terrible for getting good shrinks out of QuickCheck.
Configuration menu - View commit details
-
Copy full SHA for 060ff15 - Browse repository at this point
Copy the full SHA 060ff15View commit details -
Don't slice the result-set until `enough_results` has been determined.
Configuration menu - View commit details
-
Copy full SHA for b0d53d4 - Browse repository at this point
Copy the full SHA b0d53d4View commit details -
Update the list objects FSM and EQC test to support the 'NextMarker' XML node. This is used when a `delimiter` is included in a request. The client uses this node to page through the next request, as opposed to simply using the last `Key` in the contents.
Configuration menu - View commit details
-
Copy full SHA for 124aefb - Browse repository at this point
Copy the full SHA 124aefbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97f66b9 - Browse repository at this point
Copy the full SHA 97f66b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dbbfc9 - Browse repository at this point
Copy the full SHA 1dbbfc9View commit details -
Only use the `skip_past_prefix_and_delimiter` trick if the common delimiter is already in the result-set. It will _not_ be in the result-set if the sole object which 'created' it is not in the `active` state.
Configuration menu - View commit details
-
Copy full SHA for 80da643 - Browse repository at this point
Copy the full SHA 80da643View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46a11b0 - Browse repository at this point
Copy the full SHA 46a11b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c36b9a - Browse repository at this point
Copy the full SHA 3c36b9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for da74fd2 - Browse repository at this point
Copy the full SHA da74fd2View commit details
Commits on Feb 4, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 9be3b86 - Browse repository at this point
Copy the full SHA 9be3b86View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.