Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List objects FSM v2 bugfix and tests #788

Commits on Feb 3, 2014

  1. Add riak_test for 781

    reiddraper committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    4a638a9 View commit details
    Browse the repository at this point in the history
  2. EQC properties for listing all objects

    - Two EQC properties for listing objects (GET Bucket),
      one without delimiter and one with delimiter "/".
      Those properties assert following two are equal:
      1. keys from listing objects by repetitive usage of
         riak_cs_list_objects_fsm_v2
      2. active keys from generated [{State, Key},...]
    
    - When counterexample is found, states and keys are
      written to file $PWD/.riak_cs_list_objects_fsm_v2_eqc.txt.
      Each line consists of line number, status and key.
      Example output:
    
        1,active,0123456/10
        2,scheduled_delete,0123456/1000
    
    - To generate manifests, generator of whole manifests is avoided
      and generate only states and keys of manifests.
      The property list-all-objects generates several thousands of nested tuples,
      #lfs_manifest_v3 and #acl_v2 in this case.
      But generators of nested tuples seem not so fast.
    
    TODOs remaining
    - prefix of request parameter
    - non-default max-keys
    shino authored and reiddraper committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    9c81b9c View commit details
    Browse the repository at this point in the history
  3. Smaller EQC test constants

    Clean up the list objects EQC test and start threading the 2i request
    page size through spawn_link of the FSM. This allows us to test with
    constants far below 1002. 1002 is a nice size for production 2i queries,
    but is terrible for getting good shrinks out of QuickCheck.
    reiddraper committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    060ff15 View commit details
    Browse the repository at this point in the history
  4. Fix list objects v2 bug

    Don't slice the result-set until `enough_results` has been determined.
    reiddraper committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    b0d53d4 View commit details
    Browse the repository at this point in the history
  5. NextMarker support

    Update the list objects FSM and EQC test to support the 'NextMarker' XML
    node. This is used when a `delimiter` is included in a request. The
    client uses this node to page through the next request, as opposed to
    simply using the last `Key` in the contents.
    reiddraper committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    124aefb View commit details
    Browse the repository at this point in the history
  6. Refactor

    shino authored and reiddraper committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    97f66b9 View commit details
    Browse the repository at this point in the history
  7. Add flavor for prefix generator

    shino authored and reiddraper committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    1dbbfc9 View commit details
    Browse the repository at this point in the history
  8. Fix list objects edge-case

    Only use the `skip_past_prefix_and_delimiter` trick if the common
    delimiter is already in the result-set. It will _not_ be in the
    result-set if the sole object which 'created' it is not in the `active`
    state.
    reiddraper committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    80da643 View commit details
    Browse the repository at this point in the history
  9. Update .gitignore

    reiddraper committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    46a11b0 View commit details
    Browse the repository at this point in the history
  10. Update type specification

    reiddraper committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    3c36b9a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    da74fd2 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2014

  1. Configuration menu
    Copy the full SHA
    9be3b86 View commit details
    Browse the repository at this point in the history