Bugfix/gh782 acl xml format #793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or maybe I'd open this against 1.4 branch? |
|
Agree. > 1.4 |
|
Yes, let's try and get this into 1.4.5. |
| %% these types should be defined in xmerl.hrl or xmerl.erl | ||
| %% for now they're defined here for convenience. | ||
| -type xmlElement() :: #xmlElement{}. | ||
| -type xmlText() :: #xmlText{}. |
There was a problem hiding this comment.
xmlElement and xmlText should be exported types (thanks dialyzer)
There was a problem hiding this comment.
This is fixed in #795
|
Reopened an issue against release/1.4 => #795. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause for #782 was misuse of
xmerl_scan:string/2, which doesn't emit spaces, comments between actual xml elements. It leaves them as#xmlText{}and#xmlComment{}- This pull request commit changes to ignore them at walking around parsed dom tree.This diffset also includes a small refactoring that wraps all
xmerl_scan:string/2to oneriak_cs_xmlfuncsion to control its usage.