Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle well-indented XML including comments #795

Merged
merged 1 commit into from
Feb 8, 2014

Commits on Feb 6, 2014

  1. Handle well-indented XML including comments

    The root cause for #782 was misuse of xmerl_scan:string/2,
    which doesn't emit spaces, comments between actual xml elements.
    It leaves them as #xmlText{} and #xmlComment{} - This commit
    changes to ignore them at walking around parsed dom tree. This
    diffset also includes a small refactoring that wraps all
    xmerl_scan:string/2 to one riak_cs_xml funcsion to control its
    usage.
    
    This also adds regression test as simple eunit test case.
    
    Conflicts:
    	src/riak_cs_acl_utils.erl
    	src/riak_cs_s3_response.erl
    kuenishi committed Feb 6, 2014
    Configuration menu
    Copy the full SHA
    569b657 View commit details
    Browse the repository at this point in the history