Performance optimization for object listing requests using a prefix #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use prefix in start key calculation when appropriate to avoid iterating over unnecessary keys that lexicographically sort less than the prefix. The make_start_key_from_marker function in riak_cs_list_objects_fsm_v2 is renamed to make_start_key_from_marker_and_prefix. * Terminate processing early when a prefix is specified and a key is reached that lexicographically sorts greater than the prefix, but does not begin with the prefix. The results come back in sorted key order so it can be assumed that once any keys that begin with the prefix are processed it is appropriate to cease processing without requesting any more data. This is accomplished by the addition of the reached_end-of_keyspace/4 function to the riak_cs_list_objects_fsm_v2 module. * Silence extraneous console logging in riak_cs_list_objects_fsm_v2_eqc test
|
|
Nice work @kellymclaughlin. 👍 |
|
Is this #802 related? |
|
Yep. It's the fix for that. On Tue, Feb 11, 2014 at 10:07 PM, Shunichi Shinohara <
|
|
Thanks for taking care of this, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iterating over unnecessary keys that lexicographically sort less
than the prefix. The make_start_key_from_marker function in
riak_cs_list_objects_fsm_v2 is renamed to
make_start_key_from_marker_and_prefix.
reached that lexicographically sorts greater than the prefix, but
does not begin with the prefix. The results come back in sorted key
order so it can be assumed that once any keys that begin with the
prefix are processed it is appropriate to cease processing without
requesting any more data. This is accomplished by the addition of
the reached_end-of_keyspace/4 function to the
riak_cs_list_objects_fsm_v2 module.