Add support for Cache-Control header #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 a5a4560 |
|
The |
borshop
added a commit
that referenced
this pull request
Mar 25, 2014
Add support for Cache-Control header Reviewed-by: kuenishi
|
r_t passed. |
|
@borshop merge |
|
@junamai2000 Thank you for contribution. Though I already merged, by any chance could you write tests? It's easy, put some codes with boto into client_test. Or riak_test would be also fine. |
|
I wrote test codes for this change, but something wrong in my environment and I can not run the test codes. Could you run tests for me if I make a pull request? |
|
Sure! In some cases running Python client_tests could be difficult due to version dependency or whatever. |
|
Could you check my codes? #836 |
|
@junamai2000 Thank you for contribution. We'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting Cache-Control header is useful to communicate with CDN. S3 supports this header.