Fix PB connection pool (pbc_pool_master) leaks #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes premature pbc checkin to the pool. See also: 60b32b3
|
push one commit to address @kuenishi 's comment |
|
Fix in multibag side is needed. So change dep reference to its master branch. |
| @@ -54,5 +54,5 @@ | |||
|
|
|||
| {deps_ee, [ | |||
| {riak_repl_pb_api,".*",{git,"git@github.com:basho/riak_repl_pb_api.git", {tag, "0.2.5"}}}, | |||
| {riak_cs_multibag,".*",{git,"git@github.com:basho/riak_cs_multibag.git", {tag, "1.5.0"}}} | |||
| {riak_cs_multibag,".*",{git,"git@github.com:basho/riak_cs_multibag.git", {branch, "master"}}} | |||
There was a problem hiding this comment.
I would merge the fix in riak_cs_multibag, create a new tag on that repo, and update this prior to merging. Otherwise you're introducing nondeterminism into the build.
shino
force-pushed
the
bugfix/pbc-pool-leak
branch
2 times, most recently
from
d9f6fd1
to
20b1265
Compare
shino
force-pushed
the
bugfix/pbc-pool-leak
branch
from
20b1265
to
b6ab122
Compare
borshop
added a commit
that referenced
this pull request
Oct 7, 2014
Fix PB connection pool (pbc_pool_master) leaks Reviewed-by: kuenishi
|
@borshop merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two cases described in #985 .
The specfic requests are in the comment of the above issue.
#985 (comment)