Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Erlang 17. #1085

Merged
merged 8 commits into from Feb 27, 2015
Merged

Add support for Erlang 17. #1085

merged 8 commits into from Feb 27, 2015

Conversation

cmeiklejohn
Copy link
Contributor

No description provided.

@cmeiklejohn
Add support for Erlang 17.
48ed953
@cmeiklejohn
Bump rebar.
4b153fa
@cmeiklejohn
Bump rebar.
5feaf85
@cmeiklejohn
Bump rebar.
f225fce
@cmeiklejohn
Detect earlier set_env.
fc0b11b 
application:set_env's 4th argument has now changed, and takes a property
list.  Adapt existing code to detect the Erlang version, and make the
appropriate call.
@cmeiklejohn
Copy link
Contributor Author

@seancribbs Any thoughts about these errors on this branch?

     1) riak_kv_pb_object:empty_bucket_key_test_/0:398: RpbPutReq with empty key is disallowed
     Failure/Error: {error,undef,
                        [{riak_pb_messages,msg_code,[rpbputreq],[]},
                         {riak_kv_pb_object,request,1,
                             [{file,"src/riak_kv_pb_object.erl"},{line,415}]},
                         {riak_kv_pb_object,
                             '-empty_bucket_key_test_/0-fun-1-',0,
                             [{file,"src/riak_kv_pb_object.erl"},
                              {line,398}]}]}

  2) riak_kv_pb_object:empty_bucket_key_test_/0:402: RpbPutReq with empty bucket is disallowed
     Failure/Error: {error,undef,
                        [{riak_pb_messages,msg_code,[rpbputreq],[]},
                         {riak_kv_pb_object,request,1,
                             [{file,"src/riak_kv_pb_object.erl"},{line,415}]},
                         {riak_kv_pb_object,
                             '-empty_bucket_key_test_/0-fun-3-',0,
                             [{file,"src/riak_kv_pb_object.erl"},
                              {line,402}]}]}

  3) riak_kv_pb_object:empty_bucket_key_test_/0:406: RpbGetReq with empty key is disallowed
     Failure/Error: {error,undef,
                        [{riak_pb_messages,msg_code,[rpbgetreq],[]},
                         {riak_kv_pb_object,request,1,
                             [{file,"src/riak_kv_pb_object.erl"},{line,415}]},
                         {riak_kv_pb_object,
                             '-empty_bucket_key_test_/0-fun-5-',0,
                             [{file,"src/riak_kv_pb_object.erl"},
                              {line,406}]}]}

  4) riak_kv_pb_object:empty_bucket_key_test_/0:409: RpbGetReq with empty bucket is disallowed
     Failure/Error: {error,undef,
                        [{riak_pb_messages,msg_code,[rpbgetreq],[]},
                         {riak_kv_pb_object,request,1,
                             [{file,"src/riak_kv_pb_object.erl"},{line,415}]},
                         {riak_kv_pb_object,
                             '-empty_bucket_key_test_/0-fun-7-',0,
                             [{file,"src/riak_kv_pb_object.erl"},
                              {line,409}]}]}

@cmeiklejohn
Copy link
Contributor Author

Ah, I think I know what the problem is here.

@cmeiklejohn
Correctly type prepare_index_query.
3bee1bd 
Correctly type the prepare_index_query function.
@seancribbs
Copy link
Contributor

@cmeiklejohn Yeah, that has to do with the message code generation on riak_pb. I'm currently assigned that bug, but you may take it if you like.

@cmeiklejohn
Copy link
Contributor Author

Can you link me the bug?

@seancribbs
Copy link
Contributor

basho/riak_pb#95 (RIAK-1555)

@cmeiklejohn
Copy link
Contributor Author

Requires basho/riak_api#81.

@cmeiklejohn
Ignore warnings about prepare_index_query.
83c8016 
For some reason, Dialyzer believes that the caller to this function will
only be undefined or {_, _}, but it's unclear where this assumption is
coming from; the caller of this function comes in through a coverage
query through riak_core, so dialyzer is deriving this call from some
unknown place.

Ignore the warnings for the time being.
@cmeiklejohn
Ignore dialyzer warnings for diff_index_specs.
16a81d4 
Ignore the warnings that say the function isn't typed correctly; the
type signatures for each function are correct.
@andrewjstone
Copy link
Contributor

@borshop: retry

@andrewjstone
Copy link
Contributor

👍 16a81d4

borshop added a commit that referenced this pull request Feb 27, 2015
@borshop
Merge pull request #1085 from basho/17
d089c07 
Add support for Erlang 17.

Reviewed-by: andrewjstone
borshop added a commit that referenced this pull request Feb 27, 2015
@borshop
Merge pull request #1085 from basho/17
04bf511 
Add support for Erlang 17.

Reviewed-by: andrewjstone
borshop added a commit that referenced this pull request Feb 27, 2015
@borshop
Merge pull request #1085 from basho/17
7cb61bf 
Add support for Erlang 17.

Reviewed-by: andrewjstone
@cmeiklejohn
Copy link
Contributor Author

@borshop merge

@borshop borshop merged commit 16a81d4 into develop Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cmeiklejohn @seancribbs @andrewjstone @borshop