start key has timestamp of first value RTS-977 #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2016 14:44
…o the correct partition for the first key we want to return.
…rect the start key.
| StartKey, | ||
| EndKey, | ||
| {filter, {'=', {field, <<"weather">>, varchar}, {const, <<"yankee">>}}}, | ||
| {start_inclusive, false} | ||
| {filter, {'=', {field, <<"weather">>, varchar}, {const, <<"yankee">>}}} |
There was a problem hiding this comment.
It would probably be nice to have a non-optional start_inclusive flag.
|
+1 daaffa5 Posted two comments, but no change in code is expected. |
borshop
added a commit
that referenced
this pull request
Mar 16, 2016
start key has timestamp of first value RTS-977 Reviewed-by: hmmr
|
@borshop merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Riak TS uses the start key to hash to a vnode and does not take into account the start_inclusive filter.
This query produces a first sub query with a key from 1999..3000, this hashes to the 1999 quantum which will not contain the results from 2000..3000. The result set will have missing objects.
This bug only manifests when using the
>operator with a right hand value one less than the quanta boundary.This change increments the start key by one and removing the
{start_inclusive,false}filter when it exists to produce a start key of 2000..3000 in the first sub query, the start key hashes to the vnode where the data is actually stored. Fitler>=is not affected because the right hand value is