Add async job switches #1459
Merged
Add async job switches #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment in the check
…ment branch! * Leaving erlang_js at a tag because it's way behind current and I don't want to investigate whether it still supports R16. Format per RIAK-2559 branch's rebar.config so the eventual merge won't hurt so much.
basho/tools.mk#13 Changing as a separate commit in case any problems arise, but it seems solid.
We should forbid the operation if *either* of these clauses return true, not just if they both do.
Egregious...
And update associated unit test to match.
2 tasks
This was referenced Aug 15, 2016
| true -> | ||
| case check_bucket_type(Type) of | ||
| {ok, GoodType} -> | ||
| do_list_buckets(GoodType, T, S, Req, State); | ||
| error -> | ||
| {error, {format, "No bucket-type named '~s'", [Type]}, State} |
There was a problem hiding this comment.
Small request for the future: if/when you break up long lines, could you do it in its own separate commit? It adds a little bit of friction to the review process when I have to look at the diff and mentally filter out what's an actual change vs what's just being reformatted.
Refactored to reduce code duplication and increase clarity.
We use four spaces for each indentation level elsewhere, so new code should follow that convention.
The new code has no clause to handle stream=undefined, which is what we'll get in that one backwards compatibility case.
…traction Refactored riak_kv_pb_index and riak_kv_pb_bucket (version 2) Reviewed-by: JeetKunDoug
|
+1 8e0233b |
borshop
added a commit
that referenced
this pull request
Sep 1, 2016
Add async job switches Reviewed-by: nickelization
|
@borshop merge |
|
already merged _[posted via JIRA by Patricia Brewer]_ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds switches for the following operations arriving through HTTP or protobuf interfaces:
Caveats:
map_reduce_js, meant to control map-reduce jobs using embedded javascript, is not handled distinctly frommap_reduce, as we have not yet identified an efficient way to determine whether or not a submitted job actually uses JS at the outer boundary where filtering is implemented.