Add permissions to crdt requests. #669
Conversation
| @@ -214,3 +215,8 @@ get_context(Ctx, true) -> | |||
| mods_match(BucketMod, OpType) -> | |||
| OpMod = riak_kv_crdt:to_mod(OpType), | |||
| OpMod == BucketMod. | |||
|
|
|||
| permission_for(#dtupdatereq{bucket=B, type=T}) -> | |||
There was a problem hiding this comment.
Will type always be a binary here? Never undefined?
There was a problem hiding this comment.
type is required bytes in the protobuffs message.
|
Looks good to me. And wow. Is that it? Bravo @Vagabond for making it so neat. |
|
Yes, this is all you need. +1 from me, although a test would be nice (maybe added to the pb_security test in the security riak_test PR: basho/riak_test#385 ) |
|
@Vagabond I'll add to basho/riak_test#385. @russelldb We'll have to add them to HTTP when we get around to solidifying that API. |
|
I've rebased this so it applies cleanly. Still need a test in pb_security, I suppose. |
|
^^ @lenary pb_security and http_security need additions if you have time. If not, I'll add them next week. |
|
test passes now, are you going to get this merged too? |
|
yup yup |
Add permissions to crdt requests.
@Vagabond @russelldb