Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/mw/repl wm stats multiple fs sources #556

Merged
merged 2 commits into from Mar 10, 2014

Conversation

lordnull
Copy link
Contributor

@lordnull lordnull commented Mar 6, 2014

Addresses #555 for 1.4 branch. Primary considerations: unit tests pass, fix for 2.0 discussion.

@cmeiklejohn
Copy link
Contributor

Thanks for jumping on this fix so quickly; is this needed for the 1.3 or 2.0 releases as well?

@lordnull
Copy link
Contributor Author

lordnull commented Mar 7, 2014

Pretty certain this exists in both branches. Porting shouldn't be a problem since it's rather small change.

@lukebakken
Copy link
Contributor

@lordnull @cmeiklejohn - is there an ETA I could provide to the customer waiting on a patch for this?

@andrewjstone
Copy link
Contributor

  • code inspection
  • jsonify test
  • replication2

@andrewjstone
Copy link
Contributor

The tests pass, but another file needs to be fixed first.

test/riak_core_cluster_mgr_sup_tests.erl:4: can't find include lib "riak_core/include/riak_core_connection.hrl"
ERROR: eunit failed while processing /Users/ajs/riak_ee/deps/riak_repl: rebar_abort

Will +1 after that fix.

@cmeiklejohn
Copy link
Contributor

@lordnull Can we get this fixed and merged Monday morning so we can ship this patch? That is, unless shipping this weekend is important, and if so, I can provide the fixes this weekend. @lukebakken?

@lukebakken
Copy link
Contributor

Monday's perfectly fine.

@andrewjstone
Copy link
Contributor

👍

lordnull added a commit that referenced this pull request Mar 10, 2014
…ources

Fixes wm stats crash when there are multiple fs sources.
@lordnull lordnull merged commit 846bf2d into 1.4 Mar 10, 2014
@lordnull lordnull deleted the bug/mw/repl-wm-stats-multiple-fs-sources branch March 10, 2014 21:23
@lukebakken
Copy link
Contributor

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants