New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/mw/repl wm stats multiple fs sources #556
Conversation
Thanks for jumping on this fix so quickly; is this needed for the 1.3 or 2.0 releases as well? |
Pretty certain this exists in both branches. Porting shouldn't be a problem since it's rather small change. |
@lordnull @cmeiklejohn - is there an ETA I could provide to the customer waiting on a patch for this? |
|
The tests pass, but another file needs to be fixed first. test/riak_core_cluster_mgr_sup_tests.erl:4: can't find include lib "riak_core/include/riak_core_connection.hrl" Will +1 after that fix. |
@lordnull Can we get this fixed and merged Monday morning so we can ship this patch? That is, unless shipping this weekend is important, and if so, I can provide the fixes this weekend. @lukebakken? |
Monday's perfectly fine. |
👍 |
…ources Fixes wm stats crash when there are multiple fs sources.
Thanks everyone! |
Addresses #555 for 1.4 branch. Primary considerations: unit tests pass, fix for 2.0 discussion.