Fix badarg in binary construction for args to ebloom #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the issue #774 in some instances the Bucket given to ebloom was a 2-tuple (typed bucket) not a binary, and so a `badarg` was thrown. Though this does not stop repl from working, it leads to crashes and re-tries, is broken, and polutes this log. This commit fixes by ensuring a binary is passed to ebloom:insert/2 and ebloom:contains/2
|
+1 lgtm @russelldb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #774 for details.
To test:
develop-2.2make -j4 devrelrtdev_current.shbug/rdb/nhs-riak-repl-gh-774makein riak_test./riak_test -c sus_ee -b eleveldb -t tests/repl_aae_bloom.erl(Use your own rtdev config name though, unless you want my config?)The test should fail. And if you look in
~/rt/riak_ee/current/dev/dev1/log/error.logyou'll see badargs.Then
cd riak/deps/riak_replbug/rdb/nhs-riak-gh774cd ../../make devcleanmake -j4 devrelrtdev_current.shagain./riak_test -c sus_ee -b eleveldb -t tests/repl_aae_bloom.erlIt should pass.