Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticking plaster fix for basho/riak_repl#772 #779

Merged
merged 3 commits into from Mar 22, 2018
Merged

Conversation

russelldb
Copy link
Member

Changes to defaults, tests for same. See #772 for background

No riak_test, but unit tests. Hard to give you a before an after to run, therefore.

See riak_repl#772 for details. Also adds an enqueued timestamp to the
purgatory queue (??you mean retry_queue right??) so that there can be
some waiting between attempts to fullsync a locked/building remote partition.
After failing to craft a riak_test in a timely manner, elected for eunit
tests.  A little ugly thanks to the way side-effects are mixed into the
coordinator code (especially the sending/receiving of whereis messages)
Copy link

@bryanhuntesl bryanhuntesl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM - tests pass

@russelldb russelldb merged commit f6e650e into develop-2.2 Mar 22, 2018
@russelldb russelldb deleted the bug/rdb/gh772 branch March 22, 2018 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants