Enhance handoff repair tests #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test has two functions: Issue 1759 (KV). Confirm that through all the leaves and rejoins false AAE does not kick in because old state is left lingering. Issue 994 (Core). Confirm the controlling read-repair to fallbacks works as expected. Nodes that are configured not to repair fallbacks don't, but still repair primaries.
This was referenced Jan 4, 2023
Resolved "rogue repairs" caused by sequence of events sparked from key_amnesia prompted repairs, some of which occurred before transfer completed.
yorkshire-steve
approved these changes
Jan 16, 2023
Extend verify_rejoin to test partition repair via the new riak_client:repair_node() function.
yorkshire-steve
approved these changes
Jan 18, 2023
martinsumner
added a commit
that referenced
this pull request
Feb 7, 2023
* Enhance handoff repair tests * Use riak stats to confirm The test has two functions: Issue 1759 (KV). Confirm that through all the leaves and rejoins false AAE does not kick in because old state is left lingering. Issue 994 (Core). Confirm the controlling read-repair to fallbacks works as expected. Nodes that are configured not to repair fallbacks don't, but still repair primaries. * Clean of repairs - vnode_id issue Resolved "rogue repairs" caused by sequence of events sparked from key_amnesia prompted repairs, some of which occurred before transfer completed. * Log on failure * Add test for partition repair Extend verify_rejoin to test partition repair via the new riak_client:repair_node() function. * Reduce race chances
tburghart
added a commit
to OpenRiak/riak_test
that referenced
this pull request
May 21, 2024
Test PR PW when set by bucket properties (basho#1366) Extend test to use riak_client (basho#1367) Fix Riak version check in test Add tolerance for the occasional tombstone left hanging Issues of stability post partition Mas i1847 putapi (basho#1370) Enhance handoff repair tests (basho#1369) Mas delete and transfer (basho#1371) Test reliability improvements (basho#1372) Add AAE Update verify_rejoin.erl (basho#1373) Test range repl with node_confirms set to 2 (basho#1374) wday-contrib 1100 1548 Co-authored-by: Martin Sumner <martinsumner@users.noreply.github.com> Co-authored-by: Ted Burghart <tburghart@users.noreply.github.com> Co-authored-by: Fred Dushin <fadushin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify_rejoin was a completely broken test. It is now fixed, with a section added at the end to prove the impact of the configuration on fallback repairs.
verify_handoff extended to alter the batch_threhsold_count.