verify_listkeys failure #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Latest insights: it seems to happen when querying the node that has just joined the cluster. It seems ownership of the data has not been negotiated yet and that node can not provide a coverage plan for the listkeys command. This seems to be the same as basho/riak_core#228 |
Fixes issue #149, related to basho/riak_core#228 If queried right after it has joined the cluster, a node may not have the other nodes registered by the node watcher yet. Switching to waiting until all nodes in the cluster have been registered by the node watcher before performing query. Also, querying for all nodes after stopping/starting just in case, although I haven't seen problems there, but sound reasonable. Removing assert from the call to wait_until_no_pending_changes since it is already asserting internally.
|
👍 Reads sane AND passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting an "insufficient vnodes" message. I used to see that a lot, probably now infrequent. The logs:
http://basho-giddyup.herokuapp.com/#/projects/riak/scorecards/7/7-271/2079