Added some reassuring output.

[evanmcc]

Just a few lines so that the runner of the command knows that riaknostic
is running and that it exited without error.

This fixes #32, rather.

[bsparrow435]

This looks good to me, anyone else have input?

[ghost]

Another thing to note is that we tend to standardize on creating a new branch on the basho/riaknostic repo, and submitting a pull request from there, rather than forking our own repo and submitting a pull request.

It doesn't hurt anything to do it this way, but that's just the convention.

[evanmcc]

Yeah, I had another issue with this in my rebar change. It looks like a line or two has dropped out of my .emacs file over the years. I'll get that stuff fixed.

As per the convention, I have two or three (possibly bikeshed-y) concerns there:

• making new branches in the repo ends up littering the repo with branches that have to be manually reaped.
• more importantly, community members cannot do this, which leads to two different processes for different contributors
• also I kind of prefer the 'master is latest stable' strategy (this one is definitely bikesheddy)

[ghost]

I wouldn't be concerned that a check would crash riaknostic. That's what we need eunit tests for, to make sure that it doesn't occur.

If a check does crash riaknostic and a user sees it, they should just report that and we get a fix out pronto.

Check out riaknostic_check:print, since that's where it actually takes the lager messages and outputs them.

[evanmcc]

Taking yet another look at the code I am going to remove this part.
It isn't actually the important part of the patch, and the
ordering/sorting issues complicate the output too much to make it
worth the effort.

On Wed, Jun 27, 2012 at 11:00 AM, Tryn Mirell
reply@reply.github.com
wrote:

I wouldn't be concerned that a check would crash riaknostic. That's what we need eunit tests for, to make sure that it doesn't occur.

If a check does crash riaknostic and a user sees it, they should just report that and we get a fix out pronto.

Check out riaknostic_check:print, since that's where it actually takes the lager messages and outputs them.

---

Reply to this email directly or view it on GitHub:
#39 (comment)