Clean up startup/shutdown sequence for yokozuna #610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add the yz_startup_shutdown riak_test to verify that it is working as expected.
This is a (hopefully temporary) hack to allow for using the parse transform from within the yokozuna repo. See the comment in the rt_intercept_pt.erl file for further details.
| %% mechanism is found for using the rt_intercept_pt parse transform | ||
| %% external to the riak_test repository. | ||
| %% ------------------------------------------------------------------- | ||
| %% XXX |
There was a problem hiding this comment.
@zeeshanlakhani Note the temporary hack to get the parse transform to work. ^^^
We don't want any failures to abort the rest of the cleanup process in prep_stop, so ignore return values. Also, no need for the newlines in lager messages, so remove those.
|
Will be incorporated into another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #581 for background.
yz_app:prep_stopfunction.yz_startup_shutdown) that tests all of the above.