Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add AES counter bit genertors #146

Merged
merged 1 commit into from
Jun 11, 2019
Merged

ENH: Add AES counter bit genertors #146

merged 1 commit into from
Jun 11, 2019

Conversation

bashtage
Copy link
Owner

Add AES counter-based bit generator

@bashtage
Copy link
Owner Author

This pull request introduces 1 alert when merging 2b63ccb into 916d089 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #146 into master will increase coverage by 5.21%.
The diff coverage is 84.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   91.74%   96.95%   +5.21%     
==========================================
  Files          33       33              
  Lines        8887     8537     -350     
  Branches      153      129      -24     
==========================================
+ Hits         8153     8277     +124     
+ Misses        713      239     -474     
  Partials       21       21
Impacted Files Coverage Δ
randomgen/mt64.pyx 94.31% <ø> (+12.58%) ⬆️
randomgen/tests/test_against_numpy.py 99.29% <ø> (-0.01%) ⬇️
randomgen/rdrand.pyx 90.74% <ø> (+18.68%) ⬆️
randomgen/common.pyx 86.56% <100%> (+3.71%) ⬆️
randomgen/_pickle.py 86.04% <100%> (+0.33%) ⬆️
randomgen/aes.pyx 80.53% <80.53%> (ø)
randomgen/tests/test_direct.py 98.02% <93.75%> (-0.24%) ⬇️
randomgen/generator.pyx 99.42% <0%> (+7.18%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916d089...987ab69. Read the comment docs.

Add AES counter-based bit generator
@bashtage
Copy link
Owner Author

This pull request introduces 1 alert when merging 987ab69 into 916d089 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@bashtage bashtage merged commit 5272ca9 into master Jun 11, 2019
@bashtage bashtage deleted the aes branch June 11, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant