Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basicBot.js #1

Closed
wants to merge 1 commit into from
Closed

Update basicBot.js #1

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 7, 2014

No description provided.

@Yemasthui
Copy link
Contributor

What exactly does this patch? You're deleting a chat in a djAdvance event, when there is no chat object present.

@@ -684,6 +684,9 @@
var lastplay = obj.lastPlay;
if (typeof lastplay === 'undefined') return void (0);
if (basicBot.settings.songstats) API.sendChat("/me " + lastplay.media.author + " - " + lastplay.media.title + ": " + lastplay.score.positive + "W/" + lastplay.score.grabs + "G/" + lastplay.score.negative + "M.")
setTimeout(function (id) {
API.moderateDeleteChat(id);
}, 2 * 1000, chat.cid);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no chat object?

@Yemasthui Yemasthui closed this Sep 14, 2014
@GryphonEDM GryphonEDM mentioned this pull request Jan 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant