Video-54-Add-Category-Sidebar-And-Filter #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macronius
reviewed
May 31, 2021
| @@ -35,6 +38,22 @@ export const productListReducer = ( | |||
| } | |||
| }; | |||
|
|
|||
| export const productCategoryListReducer = ( | |||
| state = { loading: true, products: [] }, | |||
There was a problem hiding this comment.
Why on this line was 'products' not switched to 'categories' ?
Or is it simply not being utilized at all and has nothing to do with the SUCCESS categories return, and therefore could have been deleted?
There was a problem hiding this comment.
Most likely due to the fact that we're returning distinct products based on the category property of Product. On the models there is no dedicated Category model therefore no category._id hence products cannot be switched to categories.
luxi101
reviewed
Jul 23, 2021
| export const listProducts = ({ | ||
| seller = '', | ||
| name = '', | ||
| category = '', |
There was a problem hiding this comment.
I'm getting a : TypeError: Cannot read property 'category' of undefined
There was a problem hiding this comment.
I am also facing the same error
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.