added error handling: Use node.js style Error-First Callbacks #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baslr
added a commit
that referenced
this pull request
Mar 13, 2015
…any thanks to @sweetpi) • release v1.0.0 • release npm v1.0.0
|
Hi, thanks for your contribution. I also updated the JavaScript version. So the module works right out of the box. Npm module is also released as version 1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for creating this module. I've added error handling, so errors can be handled in the client.
It uses standard Node.js Error-First Callbacks. Would be nice if you release a new version with this changes to npm.