-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows directories are troublesome for repoman exec #20
Comments
Hey Andreas, thanks for the detailed report. Do you have a pull request for me? 😇 |
Oh you rascal. 😛 |
No, the fix is not enough. The command for repoman exec is processed with some rather exotic string templating engine and it appers this engine does not play nicely with backslashes. I'll replace it with something else and try again. I'll let you know if I have something you can test. |
Another note: Maybe it's not even necessary to replace the slash with a backslash. Usually I am using git bash to execute repoman under windows, where i knew it's possible to use slashes. But even the windows cmd knows how to interpret slashes. |
This makes repoman exec work on Windows. It makes also sense for *nix OSes so that the command is only executed when the directory change succeeds. closes #20
- Replace pathseparator in commands with system dependent character - Use && instead of ; as separator for multiple commands in one line. This makes repoman exec work on Windows. It makes also sense for *nix OSes so that the command is only executed when the directory change succeeds. closes #20
This should be fixed in 1.0.0. For the record, the main problem was not the path separator ( I did not do anything for the change-the-drive issue. I believe situations where .repoman.json is on a different drive than the individual repositories are very rare, if this can occur at all. This would warrant a separate issue. |
\o/ |
It appears that you can't use repoman exec with windows.
Simple example:
Assume you have the following structure:
The
.repoman.json
can be found under D:\workspace.If you execute from there
repoman exec 'dir'
you get as result:If you execute
repoman exec 'cd {workspace}' -v
you get as result:I assume repoman as trouble with the windows backslash. Would be great if that could be fixed :)
The text was updated successfully, but these errors were encountered: