Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO Compliant Fetch Calls #258

Merged
merged 9 commits into from
Sep 13, 2021

Conversation

mcclurec
Copy link
Contributor

Description

When making fetch calls for data to populate special tiles like Pi-Hole, we should include any credentials stored as cookies for the domain. This enables support for multiple subdomains fronted by a single sign one auth provider. e.g. homer.example.com tries to reach out to get data from pihole.example.com, where both of these share a common auth provider. Without including credentials in the fetch, the call would fail as it would get redirected to login.example.com

Fixes # (issue): N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mcclurec, thanks for contributing. credentials: "include" should help with auth proxies, let's merge that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants