Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credentials: "include" back to Radarr` #2

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Conversation

mcclurec
Copy link
Owner

@mcclurec mcclurec commented Sep 22, 2021

Description

credentials: "include" was mistakenly removed from the Sonarr and Radarr components when migrating the API key from a header to a query param. This PR adds the fetch option back to support set ups with SSO providers like Authelia and others. Similar to PR-258

Fixes # (issue)
Possibly bastienwirtz#251. That assumes they're running an SSO like Authelia, and the JSON parse data is because it's getting the login page HTML instead of the API JSON. Can't tell without more info on the Issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@mcclurec mcclurec merged commit b2a31c0 into main Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant