Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements multi selector for library type for Emby/Jellyfin. Allows… #785

Closed
wants to merge 1 commit into from

Conversation

cmatute7712
Copy link

@cmatute7712 cmatute7712 commented Jun 1, 2024

homer-jellyfin-multi-library

Description

Imeplements multi selector for library type for Emby/Jellyfin. Allows for comma/space separated values as input rather than matching on equals. Also updated docs to reflect change

Fixes #681

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

͡° ͜ʖ ͡°

… for comma/space separated values as input rather than matching on equals. Also updated docs to reflect change (resolves #681)
Copy link

netlify bot commented Jun 1, 2024

Deploy Preview for homer-demo-content failed.

Name Link
🔨 Latest commit c66724a
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/665b313a538dcd00087242de

@emilywotruba
Copy link
Contributor

You use a string of comma separated keywords instead of an array of strings, why? Compare to the HomeAssistant's component multi selector, which uses an array that also determines order of elements. Other than that I like it.

@cmatute7712
Copy link
Author

@emilywotruba I had't thought of that, wonderful idea. Will monkey around and see what I come up with. Keep an eye out :)

@cmatute7712
Copy link
Author

Will re-open with array of strings over string splitting

@cmatute7712 cmatute7712 closed this Jun 1, 2024
@cmatute7712 cmatute7712 changed the title Imeplements multi selector for library type for Emby/Jellyfin. Allows… Implements multi selector for library type for Emby/Jellyfin. Allows… Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jellyfin: show both movies and series counter?
2 participants