added a view-helper to get the primary-language #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svycka
requested changes
Mar 22, 2019
| */ | ||
| namespace SlmLocale\Service; | ||
|
|
||
| use Interop\Container\ContainerInterface; |
There was a problem hiding this comment.
I think this can be Psr\Container\ContainerInterface as we require ServiceManager ^3.2
There was a problem hiding this comment.
Zend\ServiceManager\Factory\FactoryInterface is still using Interop\Container\ContainerInterface
There was a problem hiding this comment.
hmm, it looks we need to update servicemanager because they support PSR only from 3.4.0 but I guess if this is final we can change this anytime.
| use SlmLocale\View\Helper\PrimaryLanguage; | ||
| use Zend\ServiceManager\Factory\FactoryInterface; | ||
|
|
||
| class PrimaryLanguageHelperFactory implements FactoryInterface |
There was a problem hiding this comment.
why do we need to implement FactoryInterface? also, make factory final
There was a problem hiding this comment.
the factory 'FactoryInterface' is for me zf standard
| use Locale; | ||
| use Zend\View\Helper\AbstractHelper; | ||
|
|
||
| class PrimaryLanguage extends AbstractHelper |
|
still not rebased to develop. Will do when I merge. |
svycka
force-pushed
the
feature/primary-language-viewhelper
branch
from
45870a6
to
81fa578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe other ppl need it too =)