Skip to content
This repository has been archived by the owner on Oct 22, 2023. It is now read-only.

Improve the error message when the format of a property is incorrect #5

Closed
pameck opened this issue Apr 18, 2018 · 3 comments
Closed

Improve the error message when the format of a property is incorrect #5

pameck opened this issue Apr 18, 2018 · 3 comments
Labels
good first issue is:enhancement

Comments

@pameck
Copy link
Contributor

pameck commented Apr 18, 2018

When defining a property with the incorrect format, I get the following error message:

/batect-sample-java/batect.yml (line 91, column 18): Cannot deserialize value of type `int` from String "d6001": not a valid Integer value
Caused by: com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `int` from String "d6001": not a valid Integer value
 at [Source: (sun.nio.ch.ChannelInputStream); line: 91, column: 18] (through reference chain: batect.config.io.ConfigurationFile["tasks"]->java.util.LinkedHashMap["app"]->batect.config.io.TaskFromFile["run"]->batect.config.io.TaskRunConfigurationFromFile["ports"]->java.util.HashSet[0]->batect.config.PortMapping["local"])

I'm modified the property ports.local in the batect.yaml file for the batect-sample-java project


...

run:
      container: international-transfers-service
      ports:
        - local: d6001
          container: 6001

....
@charleskorn
Copy link
Collaborator

Hey @pameck, are you still interested in fixing this (and #3 and #4)? Otherwise I'll take a look at them.

@pameck
Copy link
Contributor Author

pameck commented Jun 28, 2018

Just started looking at #4 ... If I don't make a PR tonight, feel free to work on it.

@charleskorn
Copy link
Collaborator

No worries, there's no rush, just wanted to check.

charleskorn added a commit that referenced this issue Dec 23, 2020
@charleskorn
Fix the issue where unexpected output is shown for a BuildKit build w…
d330ecd 
…ith an image that uses a non-default syntax.

The output previously looked something like (note output for #3 and #4):

#1 [internal] load remote build context
#1 DONE

#2 copy /context /
#2 DONE

#3 resolve image config for docker.io/docker/dockerfile:1.1-experimental
#3 ...

#4 docker-image://docker.io/docker/dockerfile:1.1-experimental@sha256:de85b2f3a3e8a2f7fe48e8e84a65f6fdd5cd5183afa6412fff9caa6871649c44
#4 ...

#5 [internal] load metadata for docker.io/library/ruby:2.7.2
#5 DONE

#6 [ 1/12] FROM docker.io/library/ruby:2.7.2
#6 DONE

#7 [ 2/12] RUN mkdir -p /tools
#7 CACHED

#8 [ 3/12] COPY health-check.sh /tools
#8 CACHED

#9 [ 4/12] RUN mkdir -p /app
#9 CACHED

#10 [ 5/12] COPY app/Gemfile app/Gemfile.lock /app/
#10 CACHED

#11 [ 6/12] WORKDIR /app
#11 CACHED

#12 [ 7/12] RUN bundle config set deployment true
#12 CACHED

#13 [ 8/12] RUN bundle config set without development
#13 CACHED

#14 [ 9/12] RUN bundle install
#14 CACHED

#15 [10/12] COPY app/config.ru /app
#15 CACHED

#16 [11/12] COPY app/bin /app/bin
#16 CACHED

#17 [12/12] COPY app/lib /app/lib
#17 ...

#3 resolve image config for docker.io/docker/dockerfile:1.1-experimental
#3 DONE

#4 docker-image://docker.io/docker/dockerfile:1.1-experimental@sha256:de85b2f3a3e8a2f7fe48e8e84a65f6fdd5cd5183afa6412fff9caa6871649c44
#4 CACHED

#17 [12/12] COPY app/lib /app/lib
#17 CACHED

#18 exporting to image
#18 exporting layers: done
#18 writing image sha256:ace2572ab366a9153b23ccc0667cc6163a32a3cbb96bfef237a25c68005699a6: done
#18 naming to docker.io/library/batect-sample-ruby-international-transfers-service: done
#18 DONE
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue is:enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pameck @charleskorn