Skip to content
This repository has been archived by the owner on Oct 22, 2023. It is now read-only.

Improve error message for Java versions less than 8 #7

Closed
Letitia-May opened this issue Jun 1, 2018 · 5 comments
Closed

Improve error message for Java versions less than 8 #7

Letitia-May opened this issue Jun 1, 2018 · 5 comments
Labels
good first issue is:bug

Comments

@Letitia-May
Copy link

When Java version was 1.7 I got the following error:

screen shot 2018-05-28 at 6 10 44 pm
@charleskorn
Copy link
Collaborator

Thanks for the bug report @Letitia-May!

This is definitely something that needs to be fixed... while it is mentioned in a number of places that Java 8+ is required, that error message could be much, much clearer and tell you exactly what's wrong.

@Letitia-May
Copy link
Author

Thanks Charles! I didn't even realise I still had 1.7 installed and set as the default - so a clearer error message would have definitely helped in realising this was the issue sooner :)

@Letitia-May Letitia-May changed the title Batect does not run when Java version less than 1.8 Improve error message for Java versions less than 1.8 Jun 1, 2018
@charleskorn
Copy link
Collaborator

(also, GitHub tells me this is your first ever issue on GitHub... congratulations 🎉 )

@Letitia-May
Copy link
Author

It is, thanks! 😄

@Letitia-May Letitia-May changed the title Improve error message for Java versions less than 1.8 Improve error message for Java versions less than 8 Jun 1, 2018
@charleskorn
Copy link
Collaborator

This has been fixed with 27d53b6 and will be part of the next release.

Thanks again @Letitia-May!

charleskorn added a commit that referenced this issue Dec 23, 2020
@charleskorn
Fix the issue where unexpected output is shown for a BuildKit build w…
d330ecd 
…ith an image that uses a non-default syntax.

The output previously looked something like (note output for #3 and #4):

#1 [internal] load remote build context
#1 DONE

#2 copy /context /
#2 DONE

#3 resolve image config for docker.io/docker/dockerfile:1.1-experimental
#3 ...

#4 docker-image://docker.io/docker/dockerfile:1.1-experimental@sha256:de85b2f3a3e8a2f7fe48e8e84a65f6fdd5cd5183afa6412fff9caa6871649c44
#4 ...

#5 [internal] load metadata for docker.io/library/ruby:2.7.2
#5 DONE

#6 [ 1/12] FROM docker.io/library/ruby:2.7.2
#6 DONE

#7 [ 2/12] RUN mkdir -p /tools
#7 CACHED

#8 [ 3/12] COPY health-check.sh /tools
#8 CACHED

#9 [ 4/12] RUN mkdir -p /app
#9 CACHED

#10 [ 5/12] COPY app/Gemfile app/Gemfile.lock /app/
#10 CACHED

#11 [ 6/12] WORKDIR /app
#11 CACHED

#12 [ 7/12] RUN bundle config set deployment true
#12 CACHED

#13 [ 8/12] RUN bundle config set without development
#13 CACHED

#14 [ 9/12] RUN bundle install
#14 CACHED

#15 [10/12] COPY app/config.ru /app
#15 CACHED

#16 [11/12] COPY app/bin /app/bin
#16 CACHED

#17 [12/12] COPY app/lib /app/lib
#17 ...

#3 resolve image config for docker.io/docker/dockerfile:1.1-experimental
#3 DONE

#4 docker-image://docker.io/docker/dockerfile:1.1-experimental@sha256:de85b2f3a3e8a2f7fe48e8e84a65f6fdd5cd5183afa6412fff9caa6871649c44
#4 CACHED

#17 [12/12] COPY app/lib /app/lib
#17 CACHED

#18 exporting to image
#18 exporting layers: done
#18 writing image sha256:ace2572ab366a9153b23ccc0667cc6163a32a3cbb96bfef237a25c68005699a6: done
#18 naming to docker.io/library/batect-sample-ruby-international-transfers-service: done
#18 DONE
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue is:bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charleskorn @Letitia-May