Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDDReachabilityAnalysisFactory: fix for edge API visibility #2428

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

dhalperi
Copy link
Member

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@anothermattbrown anothermattbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@b5f030d). Click here to learn what that means.
The diff coverage is 76.92%.

@@            Coverage Diff            @@
##             master    #2428   +/-   ##
=========================================
  Coverage          ?   70.06%           
  Complexity        ?    18641           
=========================================
  Files             ?     1668           
  Lines             ?    84814           
  Branches          ?    10460           
=========================================
  Hits              ?    59424           
  Misses            ?    21083           
  Partials          ?     4307

@anothermattbrown anothermattbrown merged commit d1052b9 into batfish:master Oct 10, 2018
@dhalperi dhalperi deleted the fix-build-bdd branch October 10, 2018 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants