Add more detail to requeue failure #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
progwriter
reviewed
Nov 14, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ratulm)
Codecov Report
@@ Coverage Diff @@
## master #2630 +/- ##
============================================
- Coverage 70.64% 70.63% -0.02%
+ Complexity 19161 19158 -3
============================================
Files 1708 1708
Lines 85986 85987 +1
Branches 10487 10487
============================================
- Hits 60741 60733 -8
- Misses 20891 20899 +8
- Partials 4354 4355 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When task requeueing fails, add exception message to the fake task to surface a little more detail to clients
I opted out of adding stack trace as that ends up being a wall of unformatted text from the client's standpoint - but I can add that back in if the consensus is to err on the side of more data over readability.