PHC: pass flowStates to headerspace builder #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
progwriter
reviewed
Dec 12, 2018
There was a problem hiding this comment.
Quick test in PacketHeaderConstraintsTest? otherwise lgtm.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
progwriter
reviewed
Dec 12, 2018
There was a problem hiding this comment.
sorry, PacketHeaderConstraintsUtilTest
Reviewable status:
Codecov Report
@@ Coverage Diff @@
## master #2806 +/- ##
============================================
+ Coverage 71.59% 71.67% +0.07%
- Complexity 19947 20041 +94
============================================
Files 1740 1740
Lines 88092 88730 +638
Branches 10720 10813 +93
============================================
+ Hits 63071 63595 +524
- Misses 20509 20611 +102
- Partials 4512 4524 +12 |
progwriter
reviewed
Dec 12, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.