IpOwners: only consider HSRP interfaces with L3 addresses #6349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://www.cisco.com/c/en/us/td/docs/switches/lan/catalyst3750x_3560x/software/release/12-2_55_se/configuration/guide/3750xscg/swhsrp.html > All Layer 3 interfaces must have IP addresses assigned to them. Downstream code in IpOwners chooses an HSRP master with tiebreak based on L3 IPs, which could crash in some scenarios (multiple interfaces with equal priority, at least one of which had no IP.)
|
This change is |
progwriter
reviewed
Oct 21, 2020
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## master #6349 +/- ##
============================================
- Coverage 72.97% 72.95% -0.02%
+ Complexity 35102 35093 -9
============================================
Files 2828 2828
Lines 142611 142614 +3
Branches 17138 17140 +2
============================================
- Hits 104065 104050 -15
- Misses 30324 30333 +9
- Partials 8222 8231 +9
|
dhalperi
commented
Oct 21, 2020
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 1 of 1 files at r2.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.cisco.com/c/en/us/td/docs/switches/lan/catalyst3750x_3560x/software/release/12-2_55_se/configuration/guide/3750xscg/swhsrp.html
Downstream code in IpOwners chooses an HSRP master with tiebreak
based on L3 IPs, which could crash in some scenarios (multiple
interfaces with equal priority, at least one of which had no
IP.)