Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IpOwners: only consider HSRP interfaces with L3 addresses #6349

Merged
merged 2 commits into from
Oct 21, 2020
Merged

IpOwners: only consider HSRP interfaces with L3 addresses #6349

merged 2 commits into from
Oct 21, 2020

Commits on Oct 21, 2020

  1. IpOwners: only consider HSRP interfaces with L3 addresses 

    https://www.cisco.com/c/en/us/td/docs/switches/lan/catalyst3750x_3560x/software/release/12-2_55_se/configuration/guide/3750xscg/swhsrp.html

> All Layer 3 interfaces must have IP addresses assigned to them.

Downstream code in IpOwners chooses an HSRP master with tiebreak
based on L3 IPs, which could crash in some scenarios (multiple
interfaces with equal priority, at least one of which had no
IP.)
    @dhalperi
    dhalperi committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    a46474f View commit details
    Browse the repository at this point in the history

  2. update unit test

    @dhalperi
    dhalperi committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    c19f8c0 View commit details
    Browse the repository at this point in the history