Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS dynamic NAT rule order: sort by ACL name #6527

Merged
merged 2 commits into from Dec 29, 2020
Merged

Conversation

corinaminer
Copy link
Contributor

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #6527 (621769a) into master (95c4e2b) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##             master    #6527      +/-   ##
============================================
- Coverage     73.36%   73.35%   -0.02%     
+ Complexity    35604    35602       -2     
============================================
  Files          2830     2830              
  Lines        143754   143771      +17     
  Branches      17366    17370       +4     
============================================
- Hits         105471   105467       -4     
- Misses        29936    29951      +15     
- Partials       8347     8353       +6     
Impacted Files Coverage Δ Complexity Δ
...tfish/representation/cisco/CiscoIosDynamicNat.java 75.53% <88.88%> (+2.80%) 28.00 <6.00> (+5.00)
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) 6.00% <0.00%> (-1.00%)
...rg/batfish/identifiers/StorageBasedIdResolver.java 85.29% <0.00%> (-5.89%) 22.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) 15.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 86.19% <0.00%> (-0.95%) 249.00% <0.00%> (ø%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.72% <0.00%> (-0.34%) 207.00% <0.00%> (-1.00%)
...a/org/batfish/representation/aws/LoadBalancer.java 82.18% <0.00%> (-0.32%) 70.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.96% <0.00%> (-0.16%) 248.00% <0.00%> (ø%)
... and 1 more

@dhalperi dhalperi requested review from progwriter and removed request for dhalperi December 28, 2020 21:23
@dhalperi
Copy link
Member

@progwriter was going to take a brief look at this one.

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 2cb76db into master Dec 29, 2020
@dhalperi dhalperi deleted the ios-nat-compare branch December 29, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants