IOS NAT rules with interface instead of pool #6528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
corinaminer
force-pushed
the
ios-nat-interface
branch
from
04aa611
to
b1c4003
Compare
Codecov Report
@@ Coverage Diff @@
## master #6528 +/- ##
============================================
- Coverage 73.36% 73.35% -0.01%
- Complexity 35610 35612 +2
============================================
Files 2830 2830
Lines 143783 143817 +34
Branches 17372 17377 +5
============================================
+ Hits 105488 105500 +12
- Misses 29942 29958 +16
- Partials 8353 8359 +6 |
corinaminer
force-pushed
the
ios-nat-interface
branch
from
b1c4003
to
650a83d
Compare
dhalperi
reviewed
Dec 29, 2020
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support dynamic NAT rules of this form:
ip nat inside source list 1 pool pool1But it is possible to use an interface in place of a pool. This causes the interface's address to be the sole member of the pool (IOS console automatically adds
overloadto this line to allow for more than one NAT entry):ip nat inside source list 1 interface Ethernet1/1Still to do: This PR does not support NAT rules of the above form where the interface is inactive or has no address; such rules will be ignored. However, on real IOS devices, these rules still match traffic, and matched traffic is dropped.
After #6524 and #6527 (which impacts test).