Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juniper: handle full range of local-pref values #6644

Merged
merged 2 commits into from Feb 19, 2021

Conversation

dhalperi
Copy link
Member

  1. Use uint32 to accurately parse the exact range.
  2. They are longs, not ints.
  3. Fix VI representation and other parsers.

This is for #6335 and a lot more.

@batfish-bot
Copy link

This change is Reviewable

1. Use uint32 to accurately parse the exact range.
2. They are longs, not ints.
3. Fix VI representation and other parsers.
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #6644 (c5db23f) into master (b51b78a) will decrease coverage by 0.00%.
The diff coverage is 94.44%.

@@             Coverage Diff              @@
##             master    #6644      +/-   ##
============================================
- Coverage     73.46%   73.45%   -0.01%     
- Complexity    36465    36468       +3     
============================================
  Files          2917     2917              
  Lines        146879   146887       +8     
  Branches      17709    17710       +1     
============================================
- Hits         107900   107897       -3     
- Misses        30478    30485       +7     
- Partials       8501     8505       +4     
Impacted Files Coverage Δ Complexity Δ
...va/org/batfish/representation/juniper/PsFroms.java 89.15% <ø> (+3.61%) 33.00 <0.00> (+1.00)
.../representation/juniper/PsFromLocalPreference.java 83.33% <88.88%> (+83.33%) 6.00 <6.00> (+6.00)
...odel/routing_policy/expr/MatchLocalPreference.java 50.00% <100.00%> (ø) 6.00 <1.00> (ø)
...grammar/cisco_xr/CiscoXrControlPlaneExtractor.java 20.12% <100.00%> (ø) 341.00 <0.00> (ø)
...fish/grammar/flatjuniper/ConfigurationBuilder.java 72.52% <100.00%> (+0.09%) 872.00 <2.00> (+2.00)
...on/cisco_xr/RoutePolicyBooleanLocalPreference.java 83.33% <100.00%> (ø) 2.00 <1.00> (ø)
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
...rg/batfish/identifiers/StorageBasedIdResolver.java 85.29% <0.00%> (-5.89%) 22.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) 15.00% <0.00%> (-1.00%)
... and 5 more

Copy link
Contributor

@corinaminer corinaminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 14 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)


projects/batfish/src/main/java/org/batfish/representation/juniper/PsFroms.java, line 135 at r1 (raw file):

  @VisibleForTesting
  public @Nullable PsFromLocalPreference getFromLocalPreference() {

nit; i don't see this actually used in any tests

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

@dhalperi dhalperi merged commit d3b6cdf into batfish:master Feb 19, 2021
@dhalperi dhalperi deleted the local-pref-crash branch February 19, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants