New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Juniper: handle full range of local-pref values #6644
Conversation
1. Use uint32 to accurately parse the exact range. 2. They are longs, not ints. 3. Fix VI representation and other parsers.
4f336a1
to
c5d09bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #6644 +/- ##
============================================
- Coverage 73.46% 73.45% -0.01%
- Complexity 36465 36468 +3
============================================
Files 2917 2917
Lines 146879 146887 +8
Branches 17709 17710 +1
============================================
- Hits 107900 107897 -3
- Misses 30478 30485 +7
- Partials 8501 8505 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 14 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @arifogel)
projects/batfish/src/main/java/org/batfish/representation/juniper/PsFroms.java, line 135 at r1 (raw file):
@VisibleForTesting public @Nullable PsFromLocalPreference getFromLocalPreference() {
nit; i don't see this actually used in any tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @arifogel)
This is for #6335 and a lot more.