Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRRP question: Filtering by address #7880

Closed
wants to merge 2 commits into from
Closed

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Dec 31, 2021

And add active interface columns and better column descriptions.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #7880 (086991d) into master (38405ba) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #7880      +/-   ##
============================================
- Coverage     74.10%   74.09%   -0.02%     
+ Complexity    42420    42418       -2     
============================================
  Files          3326     3326              
  Lines        166937   166955      +18     
  Branches      19976    19975       -1     
============================================
- Hits         123716   123708       -8     
- Misses        33668    33686      +18     
- Partials       9553     9561       +8     
Impacted Files Coverage Δ
...h/specifier/InferFromLocationIpSpaceSpecifier.java 71.42% <0.00%> (-28.58%) ⬇️
...rg/batfish/specifier/LocationIpSpaceSpecifier.java 60.00% <0.00%> (-3.16%) ⬇️
...ecifier/ReferenceAddressGroupIpSpaceSpecifier.java 50.00% <0.00%> (-1.86%) ⬇️
...uestion/vrrpproperties/VrrpPropertiesQuestion.java 59.09% <80.00%> (+1.19%) ⬆️
...uestion/vrrpproperties/VrrpPropertiesAnswerer.java 73.84% <94.73%> (+4.03%) ⬆️
...rg/batfish/specifier/ConstantIpSpaceSpecifier.java 46.66% <100.00%> (+3.80%) ⬆️
...specifier/parboiled/ParboiledIpSpaceSpecifier.java 83.63% <100.00%> (+0.30%) ⬆️
...atfish/question/specifiers/SpecifiersAnswerer.java 85.36% <100.00%> (-0.52%) ⬇️
...atfish/question/specifiers/SpecifiersQuestion.java 95.00% <100.00%> (+0.12%) ⬆️
...n/vrrpproperties/VrrpPropertiesQuestionPlugin.java 40.00% <100.00%> (ø)
... and 10 more

@ratulm
Copy link
Member Author

ratulm commented Jan 4, 2022

Closing in favor of #7889

@ratulm ratulm closed this Jan 4, 2022
@dhalperi dhalperi deleted the vrrp-address-filtering branch June 6, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants