Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRRP question: Filtering by address #7889

Merged
merged 1 commit into from Jan 4, 2022
Merged

VRRP question: Filtering by address #7889

merged 1 commit into from Jan 4, 2022

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Jan 4, 2022

And add active interface column and improve column descriptions.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #7889 (9059813) into master (bb74c2a) will increase coverage by 0.00%.
The diff coverage is 92.00%.

@@            Coverage Diff            @@
##             master    #7889   +/-   ##
=========================================
  Coverage     74.15%   74.15%           
- Complexity    42458    42461    +3     
=========================================
  Files          3327     3327           
  Lines        166934   166949   +15     
  Branches      19978    19978           
=========================================
+ Hits         123782   123794   +12     
- Misses        33590    33593    +3     
  Partials       9562     9562           
Impacted Files Coverage Δ
...uestion/vrrpproperties/VrrpPropertiesQuestion.java 59.09% <80.00%> (+1.19%) ⬆️
...uestion/vrrpproperties/VrrpPropertiesAnswerer.java 73.84% <94.73%> (+4.03%) ⬆️
...n/vrrpproperties/VrrpPropertiesQuestionPlugin.java 40.00% <100.00%> (ø)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 88.29% <0.00%> (-0.28%) ⬇️
.../datamodel/routing_policy/statement/Statement.java 81.81% <0.00%> (+9.09%) ⬆️

Copy link
Contributor

@anothermattbrown anothermattbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ratulm)

@ratulm ratulm merged commit b8e8a4b into master Jan 4, 2022
@ratulm ratulm deleted the vrrp-ipfiltering branch January 4, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants