Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HiBituninstaller-Portable #4

Merged
merged 3 commits into from
Sep 17, 2021

Conversation

Voya9e
Copy link
Contributor

@Voya9e Voya9e commented Sep 15, 2021

第一次写JSON,license不太明白,然后regex不会写。
但是我还是写了这个JSON🤣🤣🤣

@Voya9e Voya9e changed the base branch from testing to master September 16, 2021 03:01
@batkiz
Copy link
Owner

batkiz commented Sep 17, 2021

其他我看没什么问题,如果你自测没啥问题的话改好我就 merge(最近一直在用mac,我暂且没办法测试了)

@Voya9e
Copy link
Contributor Author

Voya9e commented Sep 17, 2021

其他我看没什么问题,如果你自测没啥问题的话改好我就 merge(最近一直在用mac,我暂且没办法测试了)

测试了,没啥问题。
image

@Voya9e
Copy link
Contributor Author

Voya9e commented Sep 17, 2021

我把文件名改成了有大写字母的,感觉更标准一点。

@batkiz
Copy link
Owner

batkiz commented Sep 17, 2021

ok,我个人建议把文件名里的 -portable 去掉。

scoop 本身就是偏向于 portable 的,并不需要再特意声明;一般来说 non-portable 的才会在 manifest 的文件名中标明,比如 dorado 里的 yarn-np, rustup-np 等。

@Voya9e
Copy link
Contributor Author

Voya9e commented Sep 17, 2021

ok,我个人建议把文件名里的 -portable 去掉。

scoop 本身就是偏向于 portable 的,并不需要再特意声明;一般来说 non-portable 的才会在 manifest 的文件名中标明,比如 dorado 里的 yarn-np, rustup-np 等。

这个软件确实分为两个版本,这个版本是官网界面的Portable version所以我就加上-portable了_(:зゝ∠)_

image

@Voya9e
Copy link
Contributor Author

Voya9e commented Sep 17, 2021

它的主界面会出现便携版字样:

image

然后工具菜单选项也会有所不同:

image

image

@batkiz
Copy link
Owner

batkiz commented Sep 17, 2021

好,那我 merge 了

@batkiz batkiz merged commit 46154da into batkiz:master Sep 17, 2021
@Voya9e Voya9e deleted the hibituninstallerportable2615 branch September 17, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants